New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple song previews playing in different beatmap categories… #2360

Merged
merged 6 commits into from Apr 15, 2018

Conversation

3 participants
@UselessToucan
Contributor

UselessToucan commented Apr 7, 2018

resolves #2344

@smoogipoo smoogipoo added this to the April 2018 milestone Apr 9, 2018

@smoogipoo smoogipoo removed this from the April 2018 milestone Apr 9, 2018

foreach (var beatmapContainer in Children.OfType<PaginatedBeatmapContainer>())
{
beatmapContainer.BeatmapAdded += panel => panel.PreviewPlaying.ValueChanged += isPlaying =>

This comment has been minimized.

@peppy

peppy Apr 11, 2018

Member

this is copy pasting existing logic. the logic should be centralised instead.

why not just expose an event BeganPlayingPreview which calls a method StopPlayingPreview() on all PaginatedBeatmapContainers before starting the new preview?

@@ -12,6 +14,8 @@ public class BeatmapsSection : ProfileSection
public override string Identifier => "beatmaps";
private DirectPanel currentlyPlaying;

This comment has been minimized.

@peppy

peppy Apr 15, 2018

Member

you shouldn't need this? just call StopPlaying on all sections.

This comment has been minimized.

@peppy

peppy Apr 15, 2018

Member

oh, it's not even being used

@peppy

peppy approved these changes Apr 15, 2018

@peppy peppy merged commit e512e4b into ppy:master Apr 15, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@UselessToucan UselessToucan deleted the UselessToucan:profile_multiple_audio_previews branch Apr 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment