Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all possible cases of crossthread import data races #2373

Merged
merged 1 commit into from Apr 10, 2018

Conversation

2 participants
@smoogipoo
Copy link
Contributor

smoogipoo commented Apr 9, 2018

Fixes #2364.

Also adds disposal logic to remove event bindings.

@peppy

This comment has been minimized.

Copy link
Member

peppy commented Apr 10, 2018

Was kinda hoping to avoid unsafe events like this (in favour of always having them scheduled), but let's go with this for now.

@peppy

peppy approved these changes Apr 10, 2018

@peppy peppy merged commit 9e5e2c8 into ppy:master Apr 10, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

peppy added a commit to peppy/osu that referenced this pull request Apr 11, 2018

@smoogipoo smoogipoo deleted the smoogipoo:fix-crossthread-imports branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.