-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix qualified category on rank status #2377
Conversation
Many of these are wrong (they are basd off the legacy stable api, which returns different status codes from the database). Here's the correct values if you'd like to fix the others too: const STATES = [
'graveyard' => -2,
'wip' => -1,
'pending' => 0,
'ranked' => 1,
'approved' => 2,
'qualified' => 3,
'loved' => 4,
]; |
I'm confused, it works fine as is. The implementation was right, but I think those values you gave are for states(status of a map) not categories (i.e. ranked is a state, Ranked & Approved is a category; Any is a category that has all the states; WIP is not a category at all, it is part of the pending category. |
Please update it to match and add a new enum with the following:
Call it |
I think the file was made already. |
Okay, but this one still needs to be renamed |
Sorry to be demanding, but I think this should also be moved to inside the Rationale: it's only ever used for online functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
# Conflicts: # osu.Game/Beatmaps/RankStatus.cs # osu.Game/Online/API/Requests/SearchBeatmapSetsRequest.cs # osu.Game/Overlays/Direct/FilterControl.cs # osu.Game/Overlays/DirectOverlay.cs
Qualified is actually number 3, and mod requests isn't a category at the moment.