Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove composer from player loader #2396
Conversation
peppy
added this to the April 2018 milestone
Apr 13, 2018
peppy
added
the
design
label
Apr 13, 2018
peppy
merged commit 68d865b
into
ppy:master
Apr 13, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
Joehuu
deleted the
Joehuu:remove-composer-from-player-loader
branch
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Joehuu commentedApr 13, 2018
If it was meant for the artist of the song, it is already shown on top. We should add genre and language (if it was implemented) here next time (idk how), so users will know the song features.