Hide menu cursor when taking screenshots by default #2397
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Would it be better to use |
This comment has been minimized.
This comment has been minimized.
Yes. Will use |
This comment has been minimized.
This comment has been minimized.
I checked |
@@ -18,6 +18,9 @@ namespace osu.Game.Graphics.Cursor | |||
{ | |||
public class MenuCursor : CursorContainer | |||
{ | |||
public bool ShowCursor = true; |
peppy
Apr 13, 2018
Member
no xmldoc, also don't like this. what's stopping something else from setting this for its own usage, and having them conflict?
no xmldoc, also don't like this. what's stopping something else from setting this for its own usage, and having them conflict?
protected override Drawable CreateCursor() => new Cursor(); | ||
|
||
private Bindable<bool> cursorRotate; | ||
private bool dragging; | ||
|
||
private bool startRotation; | ||
|
||
private ScreenshotManager screenshotManager; |
peppy
Apr 15, 2018
Member
no need for this?
no need for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Alternative to / closes #2309
Prereqs:
Over #2309: