Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide menu cursor when taking screenshots by default #2397

Merged
merged 17 commits into from Apr 15, 2018
Merged

Hide menu cursor when taking screenshots by default #2397

merged 17 commits into from Apr 15, 2018

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Apr 13, 2018 •
edited by peppy

Alternative to / closes #2309

Prereqs:

Over #2309:

  • Doesn't fade out the cursor using the cursor's standard Show/Hide, possibly leading to problems if something else calls Show/Hide continuously themselves.
  • Instantaneously hides the cursor for the exact amount of frames required to capture the screenshot (4), instantaneously shows it again afterwards, all through IsPresent.
  • Doesn't crash when taking screenshots in quick succession.
  • Makes TakeScreenShotAsync truly async - it was previously blocking update thread, even if only for a "short" amount of time.
  • Don't lead to the possibly of the cursor still being shown if taking screenshots in laggy scenarios.

@smoogipoo smoogipoo added this to the April 2018 milestone Apr 13, 2018
@smoogipoo smoogipoo requested a review from peppy April 13, 2018 08:53
peppy
peppy reviewed Apr 13, 2018
View reviewed changes
osu.Game/Graphics/Cursor/MenuCursor.cs Outdated
@@ -18,6 +18,9 @@ namespace osu.Game.Graphics.Cursor
{
public class MenuCursor : CursorContainer
{
public bool ShowCursor = true;

This comment was marked as off-topic.

Sign in to view

peppy
peppy reviewed Apr 15, 2018
View reviewed changes
osu.Game/Graphics/Cursor/MenuCursor.cs Outdated
protected override Drawable CreateCursor() => new Cursor();

private Bindable<bool> cursorRotate;
private bool dragging;

private bool startRotation;

private ScreenshotManager screenshotManager;

This comment was marked as off-topic.

Sign in to view

@peppy peppy changed the title Add option to hide menu cursor in screenshots Hide menu cursor when taking screenshots by default Apr 15, 2018
@peppy peppy merged commit 0490c52 into ppy:master Apr 15, 2018
@smoogipoo smoogipoo deleted the instant-hide-screenshot branch June 15, 2018 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:settings
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smoogipoo @peppy @UselessToucan @Frontear