Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make buttons only accept input when expanded #2402

Merged
merged 3 commits into from Apr 15, 2018

Conversation

@FreezyLemon
Copy link
Member

@FreezyLemon FreezyLemon commented Apr 13, 2018

Closes #2385.
I think that buttons should (at least for KB) only accept input when they are actually expanded. Not only because it fixes the bug at hand, but because it is more intuitive to the user when navigating through the menu by keyboard.

FreezyLemon and others added 2 commits Apr 13, 2018
both other states are "inactive"/invisible so should never accept keyboard input
@peppy
peppy approved these changes Apr 15, 2018
@peppy peppy merged commit af154e6 into ppy:master Apr 15, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@FreezyLemon FreezyLemon deleted the FreezyLemon:fix-button-kb-input branch Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants