Disable tab switching for add channel button #2405
Merged
Conversation
| @@ -37,6 +47,21 @@ public TestCaseTabControl() | |||
| { | |||
| text.Text = "Currently Selected: " + newFilter.ToString(); | |||
| }; | |||
|
|
|||
| AddStep("set selection to first tab", () => filter.Current.Value = filter.VisibleItems.First()); | |||
FreezyLemon
Apr 15, 2018
Member
Nitpick, but could you make these shorter? The last ones don't even fit on the buttons, and you could really just put "select first", "select next" etc.
Nitpick, but could you make these shorter? The last ones don't even fit on the buttons, and you could really just put "select first", "select next" etc.
swoolcock
Apr 15, 2018
Author
Contributor
I guess?
I guess?
|
Any reasons why tests are in osu! project and not framework? They seem to be testing basic functionality of a framework control. |
|
Fair point, I just saw that a visual test already existed in the osu! project for |
swoolcock
changed the title
|
Visual tests removed, minor change force pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Make sure the "add channel" button cannot be tab switched to.
Updates framework to include ppy/osu-framework#1363