New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tab switching for add channel button #2405

Merged
merged 3 commits into from Apr 25, 2018

Conversation

3 participants
@swoolcock
Contributor

swoolcock commented Apr 15, 2018

Make sure the "add channel" button cannot be tab switched to.

Updates framework to include ppy/osu-framework#1363

@@ -37,6 +47,21 @@ public TestCaseTabControl()
{
text.Text = "Currently Selected: " + newFilter.ToString();
};
AddStep("set selection to first tab", () => filter.Current.Value = filter.VisibleItems.First());

This comment has been minimized.

@FreezyLemon

FreezyLemon Apr 15, 2018

Member

Nitpick, but could you make these shorter? The last ones don't even fit on the buttons, and you could really just put "select first", "select next" etc.

This comment has been minimized.

@swoolcock

swoolcock Apr 15, 2018

Contributor

I guess?

@peppy peppy added the testing label Apr 16, 2018

@peppy peppy added this to the April 2018 milestone Apr 16, 2018

@peppy

This comment has been minimized.

Member

peppy commented Apr 16, 2018

Any reasons why tests are in osu! project and not framework? They seem to be testing basic functionality of a framework control.

@swoolcock

This comment has been minimized.

Contributor

swoolcock commented Apr 16, 2018

Fair point, I just saw that a visual test already existed in the osu! project for TabControl, so I piggybacked off that.

@swoolcock swoolcock changed the title from Visual tests for switchable tab control to Disable tab switching for add channel button Apr 24, 2018

@swoolcock

This comment has been minimized.

Contributor

swoolcock commented Apr 24, 2018

Visual tests removed, minor change force pushed.

@peppy

peppy approved these changes Apr 25, 2018

@peppy peppy merged commit fe0e73e into ppy:master Apr 25, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment