Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable tab switching for add channel button #2405
Conversation
| @@ -37,6 +47,21 @@ public TestCaseTabControl() | ||
| { | ||
| text.Text = "Currently Selected: " + newFilter.ToString(); | ||
| }; | ||
| AddStep("set selection to first tab", () => filter.Current.Value = filter.VisibleItems.First()); |
This comment has been minimized.
This comment has been minimized.
FreezyLemon
Apr 15, 2018
Member
Nitpick, but could you make these shorter? The last ones don't even fit on the buttons, and you could really just put "select first", "select next" etc.
This comment has been minimized.
This comment has been minimized.
peppy
added
the
testing
label
Apr 16, 2018
peppy
added this to the April 2018 milestone
Apr 16, 2018
This comment has been minimized.
This comment has been minimized.
|
Any reasons why tests are in osu! project and not framework? They seem to be testing basic functionality of a framework control. |
This comment has been minimized.
This comment has been minimized.
|
Fair point, I just saw that a visual test already existed in the osu! project for |
swoolcock
changed the title from
Visual tests for switchable tab control
to
Disable tab switching for add channel button
Apr 24, 2018
This comment has been minimized.
This comment has been minimized.
|
Visual tests removed, minor change force pushed. |
peppy
added
user interface
online / API
and removed
testing
labels
Apr 25, 2018
peppy
merged commit fe0e73e
into
ppy:master
Apr 25, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
swoolcock commentedApr 15, 2018
•
edited
Make sure the "add channel" button cannot be tab switched to.
Updates framework to include ppy/osu-framework#1363