Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tab switching for add channel button #2405

Merged
merged 3 commits into from Apr 25, 2018

Conversation

swoolcock
Copy link
Contributor

@swoolcock swoolcock commented Apr 15, 2018

Make sure the "add channel" button cannot be tab switched to.

Updates framework to include ppy/osu-framework#1363

@@ -37,6 +47,21 @@ public TestCaseTabControl()
{
text.Text = "Currently Selected: " + newFilter.ToString();
};

AddStep("set selection to first tab", () => filter.Current.Value = filter.VisibleItems.First());

This comment was marked as off-topic.

This comment was marked as off-topic.

@peppy peppy added this to the April 2018 milestone Apr 16, 2018
@peppy
Copy link
Sponsor Member

peppy commented Apr 16, 2018

Any reasons why tests are in osu! project and not framework? They seem to be testing basic functionality of a framework control.

@swoolcock
Copy link
Contributor Author

Fair point, I just saw that a visual test already existed in the osu! project for TabControl, so I piggybacked off that.

@swoolcock swoolcock changed the title Visual tests for switchable tab control Disable tab switching for add channel button Apr 24, 2018
@swoolcock
Copy link
Contributor Author

Visual tests removed, minor change force pushed.

@peppy peppy merged commit fe0e73e into ppy:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants