Fix hitobject lengths not being calculated for overlapping speed changes #2409
Conversation
smoogipoo
force-pushed the
smoogipoo:fix-overlapping-speedchanges
branch
from
8cd1874
to
ea0683a
| @@ -22,8 +23,24 @@ public void ComputeInitialStates(IEnumerable<DrawableHitObject> hitObjects, Scro | |||
| { | |||
| foreach (var obj in hitObjects) | |||
| { | |||
| var controlPoint = controlPointAt(obj.HitObject.StartTime); | |||
| obj.LifetimeStart = obj.HitObject.StartTime - timeRange / controlPoint.Multiplier; | |||
| obj.LifetimeStart = obj.HitObject.StartTime - timeRange / controlPointAt(obj.HitObject.StartTime).Multiplier; | |||
peppy
Apr 20, 2018
Member
i've looked through this like 5 times so far and i just can't understand what's going on in this method/class. can we get some in-line comments to try and help out?
i've looked through this like 5 times so far and i just can't understand what's going on in this method/class. can we get some in-line comments to try and help out?
|
thanks, this code is much more approachable now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #2359
Not sure why this wasn't implemented, an oversight I guess o_o