New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hitobject lengths not being calculated for overlapping speed changes #2409

Merged
merged 7 commits into from Apr 20, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Apr 16, 2018

Fixes #2359

Not sure why this wasn't implemented, an oversight I guess o_o

@@ -22,8 +23,24 @@ public void ComputeInitialStates(IEnumerable<DrawableHitObject> hitObjects, Scro
{
foreach (var obj in hitObjects)
{
var controlPoint = controlPointAt(obj.HitObject.StartTime);
obj.LifetimeStart = obj.HitObject.StartTime - timeRange / controlPoint.Multiplier;
obj.LifetimeStart = obj.HitObject.StartTime - timeRange / controlPointAt(obj.HitObject.StartTime).Multiplier;

This comment has been minimized.

@peppy

peppy Apr 20, 2018

Member

i've looked through this like 5 times so far and i just can't understand what's going on in this method/class. can we get some in-line comments to try and help out?

@peppy

peppy approved these changes Apr 20, 2018

thanks, this code is much more approachable now

@peppy peppy merged commit 45eaa53 into ppy:master Apr 20, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:fix-overlapping-speedchanges branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment