Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hitobject lengths not being calculated for overlapping speed changes #2409

Merged
merged 7 commits into from Apr 20, 2018

Conversation

smoogipoo
Copy link
Contributor

Fixes #2359

Not sure why this wasn't implemented, an oversight I guess o_o

@smoogipoo smoogipoo force-pushed the fix-overlapping-speedchanges branch from 8cd1874 to ea0683a Compare April 16, 2018 11:35
@@ -22,8 +23,24 @@ public void ComputeInitialStates(IEnumerable<DrawableHitObject> hitObjects, Scro
{
foreach (var obj in hitObjects)
{
var controlPoint = controlPointAt(obj.HitObject.StartTime);
obj.LifetimeStart = obj.HitObject.StartTime - timeRange / controlPoint.Multiplier;
obj.LifetimeStart = obj.HitObject.StartTime - timeRange / controlPointAt(obj.HitObject.StartTime).Multiplier;

This comment was marked as off-topic.

This comment was marked as off-topic.

Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this code is much more approachable now

@peppy peppy merged commit 45eaa53 into ppy:master Apr 20, 2018
@smoogipoo smoogipoo deleted the fix-overlapping-speedchanges branch June 15, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants