Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix hitobject lengths not being calculated for overlapping speed changes #2409
Conversation
smoogipoo
added
the
resolves issue
label
Apr 16, 2018
| @@ -22,8 +23,24 @@ public void ComputeInitialStates(IEnumerable<DrawableHitObject> hitObjects, Scro | ||
| { | ||
| foreach (var obj in hitObjects) | ||
| { | ||
| var controlPoint = controlPointAt(obj.HitObject.StartTime); | ||
| obj.LifetimeStart = obj.HitObject.StartTime - timeRange / controlPoint.Multiplier; | ||
| obj.LifetimeStart = obj.HitObject.StartTime - timeRange / controlPointAt(obj.HitObject.StartTime).Multiplier; |
This comment has been minimized.
This comment has been minimized.
peppy
Apr 20, 2018
Member
i've looked through this like 5 times so far and i just can't understand what's going on in this method/class. can we get some in-line comments to try and help out?
This comment has been minimized.
This comment has been minimized.
smoogipoo
and others
added some commits
Apr 20, 2018
peppy
merged commit 45eaa53
into
ppy:master
Apr 20, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
smoogipoo
deleted the
smoogipoo:fix-overlapping-speedchanges
branch
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
smoogipoo commentedApr 16, 2018
Fixes #2359
Not sure why this wasn't implemented, an oversight I guess o_o