New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 4.7.1 #2426

Merged
merged 6 commits into from Apr 23, 2018

Conversation

2 participants
@peppy
Member

peppy commented Apr 20, 2018

Resolves #2368.

Also adds previously fogotten ruleset test configurations to rider.

ValueTyple usage removed due to issue.

@peppy peppy added the compatibility label Apr 20, 2018

@peppy peppy added this to the April 2018 milestone Apr 20, 2018

@peppy peppy added resolves issue and removed compatibility labels Apr 20, 2018

@peppy peppy removed this from the April 2018 milestone Apr 20, 2018

@@ -0,0 +1,22 @@
<component name="ProjectRunConfigurationManager">
<configuration default="false" name="RulesetTests (catch)" type="DotNetProject" factoryName=".NET Project">
<option name="EXE_PATH" value="$PROJECT_DIR$/osu.Game.Rulesets.Catch.Tests/bin/Debug/netcoreapp2.0/osu.Game.Rulesets.Catch.Tests.dll" />

This comment has been minimized.

@smoogipoo

smoogipoo Apr 20, 2018

Contributor

Hmmm are you sure about this? All other projects (incl. framework) reference net471, except all ruleset configurations.

This comment has been minimized.

@peppy

peppy Apr 20, 2018

Member

i am not sure why i made them netcore.

@peppy peppy merged commit a6da1b4 into ppy:master Apr 23, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:net471 branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment