Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggles for beatmap skins and hitsounds #2432

Merged
merged 7 commits into from Apr 25, 2018

Conversation

@UselessToucan
Copy link
Contributor

@UselessToucan UselessToucan commented Apr 20, 2018

UselessToucan and others added 4 commits Apr 20, 2018
@peppy peppy added this to the April 2018 milestone Apr 24, 2018
peppy added 2 commits Apr 25, 2018
@peppy peppy force-pushed the UselessToucan:ignore_beatmap_skin branch from 7bf24cc to 4f53185 Apr 25, 2018
@peppy peppy changed the title Ignore beatmap skin and hitsounds Add toggles for beatmap skins and hitsounds Apr 25, 2018
@peppy
peppy approved these changes Apr 25, 2018
@peppy peppy merged commit 306f05b into ppy:master Apr 25, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@UselessToucan UselessToucan deleted the UselessToucan:ignore_beatmap_skin branch Apr 25, 2018
@AdrienBoitelle

This comment has been minimized.

Copy link

@AdrienBoitelle AdrienBoitelle commented on c517b73 Apr 25, 2018

image

On the same file, ChannelTabItem (which has "IsRemovable") doesn't have "IsSwitchable", which causes the error on my end. I don't think that you have this error because it prevents me from building, I guess you would have noticed it... but what did I do wrong then ? I just pulled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants