Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replays being played in the selected ruleset #2450

Merged
merged 2 commits into from May 2, 2018

Conversation

3 participants
@tgi74
Copy link
Contributor

tgi74 commented Apr 24, 2018

This simple fix sets the game's ruleset to the score's ruleset.
It prevents the game from crashing, trying to read ReplayFrames from a different Ruleset

@peppy peppy added replay bug labels Apr 26, 2018

@peppy peppy modified the milestones: April 2018, May 2018 Apr 26, 2018

@smoogipoo
Copy link
Contributor

smoogipoo left a comment

I'm fine with this for now since this already changes the beatmap.

@smoogipoo smoogipoo merged commit 0845041 into ppy:master May 2, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.