New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more inheritance for UserStatus #2458

Merged
merged 2 commits into from May 2, 2018

Conversation

3 participants
@4ppleCracker
Contributor

4ppleCracker commented Apr 26, 2018

Modding, playing multiplayer/singleplayer, Busy, etc are all done when user is online so they may just be a class of type UserStatusOnline(used to be UserStatusAvailable but since available and online are basically the same i just made available be online). I don’t know how PM’s are handled but i assume that the client receives the PM and then decides what to do based on your status. By doing this you can interrupt the user with the message if typeof(status) != typeof(UserStatusBusy), making multiplaying, solo game, etc not interrupt the user, but if they're are just online you can interrupt

Updated UserStatus.cs to make more sense(UNTESTED)
Untested code, on my ipad in school so i can’t compile the code or check for refrences to stuff

Modding, playing multiplayer/singleplayer, Busy, etc are all done when user is online so they may just be a class of type UserStatusOnline(used to be UserStatusAvailable but since available and online are basically the same i just made available be online). I don’t know how PM’s are handled but i assume that the client recieves the PM and then decides what to do based on your status. By doing this you can interupt the user with the message if typeof(status) != typeof(UserStatusBusy), making multiplaying, solo game, etc not interupt the user, but when typeof(status) == typeof(UserStatusBusy) show a less intrusive message box to not interupt the user
@smoogipoo

Sure, let's go with this.

@peppy peppy added the code quality label May 2, 2018

@peppy peppy added this to the Candidate Issues milestone May 2, 2018

@smoogipoo smoogipoo changed the title from Updated UserStatus.cs to make more sense(Tested Now) to Use more inheritance for UserStatus May 2, 2018

@smoogipoo smoogipoo modified the milestones: Candidate Issues, May 2018 May 2, 2018

@smoogipoo smoogipoo merged commit 6fe09ee into ppy:master May 2, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment