Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop audio playing from UserProfileOverlay when hiding (REVERTED) #2470

Merged

Conversation

UselessToucan
Copy link
Contributor

@peppy peppy changed the title Cleanup UserProfileOverlay during PopOut Stop audio playing from UserProfileOverlay when hiding May 2, 2018
@smoogipoo smoogipoo added this to the May 2018 milestone May 2, 2018
@smoogipoo smoogipoo merged commit 6779384 into ppy:master May 2, 2018
@UselessToucan UselessToucan deleted the main_track_muted_preview_overlay_closed branch May 2, 2018 06:16
smoogipoo added a commit that referenced this pull request May 2, 2018
…preview_overlay_closed"

This reverts commit 6779384.
@peppy peppy changed the title Stop audio playing from UserProfileOverlay when hiding Stop audio playing from UserProfileOverlay when hiding (REVERTED) May 2, 2018
@smoogipoo
Copy link
Contributor

Animation broken: https://puu.sh/Aetpp/b39974d795.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main audio track is muted forever if direct/profile/beatmap overlay is closed while preview is playing
3 participants