New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple FilterControl.Ruleset from the game-wide ruleset bindable #2471

Merged
merged 4 commits into from May 9, 2018

Conversation

3 participants
@UselessToucan
Contributor

UselessToucan commented Apr 29, 2018

@peppy peppy added the resolves issue label May 2, 2018

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented May 2, 2018

I don't think direct and osu! should share the game-wide ruleset bindable in the first place. Agree, @peppy ?

@peppy

This comment has been minimized.

Member

peppy commented May 2, 2018

I think that's the direction we were going in, yeah.

Also I thought this functionality already existed at an OsuScreen level or similar? I know that these buttons were already disabled when in play mode.

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented May 2, 2018

The toolbar buttons are, but the osu!direct buttons weren't disabled, and they share the game-wide bindable hence triggering the exception. But I can't imagine why you'd want to disable the direct ones.

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented May 2, 2018

Instead of this, I propose we decouple osu!direct from the game-wide ruleset bindable. It should do something like: Ruleset.Value = game?.Ruleset.Value ?? rulesets.GetRuleset(0) rather than a .BindTo().

osu!direct should dependency cache a ruleset bindable for children to use, if anything else other than this filter control needs it.

@smoogipoo smoogipoo added this to the May 2018 milestone May 2, 2018

@smoogipoo

as commented

@UselessToucan

This comment has been minimized.

Contributor

UselessToucan commented May 3, 2018

@smoogipoo smoogipoo removed this from the May 2018 milestone May 7, 2018

@UselessToucan UselessToucan changed the title from Disable RulesetToggleButton whenever the ruleset can't be changed to Decouple FilterControl.Ruleset from the game-wide ruleset bindable May 8, 2018

@smoogipoo

lgtm!

@smoogipoo smoogipoo merged commit 3c68935 into ppy:master May 9, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@UselessToucan UselessToucan deleted the UselessToucan:change_ruleset_via_direct_while_on_scorescreen branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment