New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keybind to disable mouse buttons #2483

Merged
merged 9 commits into from May 15, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented May 2, 2018

Supersedes / closes #2478.

Prereqs:

Doesn't post notifications.

@smoogipoo smoogipoo added this to the May 2018 milestone May 2, 2018

@@ -75,6 +76,8 @@ public enum GlobalAction
[Description("Quick Retry (Hold)")]
QuickRetry,
[Description("Toggle gameplay mouse buttons")]
ToggleGameplayMouseButtons,

This comment has been minimized.

@peppy

peppy May 7, 2018

Member

due to the way database storage works, this will cause the shortcut from screenshots to be transferred here (they are using the int representations) so this needs to be the last entry in the enum.

This comment has been minimized.

@smoogipoo

smoogipoo May 7, 2018

Contributor

Ah dang, you're right.

@peppy

This comment has been minimized.

Member

peppy commented May 7, 2018

This looks really weird without the keyboard shortcut being displayed..

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented May 7, 2018

Going to have to look into how to do keybindings for this stuff in general. TrackedSettings are instantiated at a ConfigManager level so they don't have access to the user's bindings, hence why I left this out here.

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented May 10, 2018

Added prereq on ppy/osu-framework#1548.

screen shot 2018-05-10 at 6 48 04 pm

screen shot 2018-05-10 at 6 48 13 pm

As discussed earlier, getting TrackedSettings to work with bindings is a bit difficult right now: #2517

@peppy

This comment has been minimized.

Member

peppy commented May 10, 2018

I think it might look better keeping the light at the same height, to avoid it flying around:

screencast 2018-05-10 19-39-28

@peppy

peppy approved these changes May 15, 2018

@peppy peppy merged commit 457b98e into ppy:master May 15, 2018

2 checks passed

CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:disable-mouse-buttons branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment