Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a mod triggers on release #2485

Merged
merged 5 commits into from May 11, 2018
Merged

Selecting a mod triggers on release #2485

merged 5 commits into from May 11, 2018

Conversation

@santerinogelainen
Copy link
Contributor

@santerinogelainen santerinogelainen commented May 2, 2018

Resolves #2392

{
switch (args.Button)
// only trigger the event if we are inside the area of the button
if (Contains(ToScreenSpace(state.Mouse.Position - Position)))

This comment has been minimized.

@Aergwyn

Aergwyn May 2, 2018
Member

Wait it does trigger the OnMouseUp of the mod button if you release while not on the button?

This comment has been minimized.

@santerinogelainen

santerinogelainen May 2, 2018
Author Contributor

Yes

This comment has been minimized.

@smoogipoo

smoogipoo May 6, 2018
Contributor

You'll want to use OnClick to avoid this.

This comment has been minimized.

@smoogipoo

smoogipoo May 6, 2018
Contributor

Hmm actually OnClick doesn't give any button args so maybe not...

@peppy peppy added the resolves issue label May 2, 2018
{
switch (args.Button)
// only trigger the event if we are inside the area of the button
if (Contains(ToScreenSpace(state.Mouse.Position - Position)))

This comment has been minimized.

@smoogipoo

smoogipoo May 6, 2018
Contributor

You'll want to use OnClick to avoid this.

@smoogipoo smoogipoo dismissed their stale review May 6, 2018

bad suggestion

peppy added 3 commits May 11, 2018
@peppy peppy dismissed their stale review via aa5d5ab May 11, 2018
@peppy
peppy approved these changes May 11, 2018
@peppy peppy merged commit 18de235 into ppy:master May 11, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.