Rework beatmap conversion process to use IBeatmap #2491
Merged
Conversation
This is a pretty hard change to review, but everything seems to be in the right place. Let's go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Prereqs:
Significant changes:
WorkingBeatmap
now exposes aGetPlayableBeatmap(RulesetInfo)
method, which returns the converted beatmap with all mods applied. Previously this was done inRulesetContainer
.IApplicableToHitObject<TObject>
is nowIApplicableToObject
.BeatmapConverter
andBeatmapProcessor
now take anIBeatmap
constructor parameter, because some of them typically need to determine if the beatmap passed in is for the current ruleset or not, prior to conversion actually happening.Currently broken:
Difficulty calculation - star difficulty is computed before aWorkingBeatmap
becomes available during the import process. This process is wrong anyway.