Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent user from scrolling outside the timeline in the editor #2499

Merged
merged 7 commits into from May 25, 2018

Conversation

@AlFasGD
Copy link
Contributor

@AlFasGD AlFasGD commented May 8, 2018

The user can no longer scroll to a time that's less than 0 or greater than the song's length. Created a new constructor, added another parameter for the already existing constructor which does not provide the song's length directly.

@peppy peppy added this to the May 2018 milestone May 9, 2018
@peppy peppy requested a review from smoogipoo May 18, 2018
@@ -15,15 +18,27 @@ namespace osu.Game.Screens.Edit
/// </summary>
public class EditorClock : DecoupleableInterpolatingFramedClock
{
//public Bindable<WorkingBeatmap> Beatmap = new Bindable<WorkingBeatmap>();

This comment has been minimized.

@smoogipoo

smoogipoo May 21, 2018
Contributor

Remove


ControlPointInfo = beatmap.Value.Beatmap.ControlPointInfo;
TrackLength = beatmap.Value.Track.Length;
}

This comment has been minimized.

@smoogipoo

smoogipoo May 21, 2018
Contributor

Add newline.

@@ -15,15 +18,27 @@ namespace osu.Game.Screens.Edit
/// </summary>
public class EditorClock : DecoupleableInterpolatingFramedClock
{
//public Bindable<WorkingBeatmap> Beatmap = new Bindable<WorkingBeatmap>();

public double TrackLength;

This comment has been minimized.

@smoogipoo

smoogipoo May 21, 2018
Contributor

Any reason for this to not be readonly?

@peppy peppy dismissed smoogipoo’s stale review May 25, 2018

has been resolved

@peppy peppy force-pushed the AlFasGD:editor-seekbar-fix branch from 88604ea to 8977670 May 25, 2018
@peppy
peppy approved these changes May 25, 2018
@peppy peppy merged commit 58317be into ppy:master May 25, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants