Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input toggles to the PlayerLoader screen #2504

Merged
merged 6 commits into from May 25, 2018
Merged

Add input toggles to the PlayerLoader screen #2504

merged 6 commits into from May 25, 2018

Conversation

UselessToucan
Copy link
Contributor

osu_2018-05-09_17-30-40

@peppy
Copy link
Sponsor Member

peppy commented May 10, 2018

Mouse buttons maybe, but I'm not sure why we need mouse wheel here. It sounds like something you'd set once and leave it in place.

The loading screen should only contain quick-access settings which are regularly changed by users.

@peppy peppy added this to the Candidate Issues milestone May 10, 2018
@peppy
Copy link
Sponsor Member

peppy commented May 21, 2018

Why did you change the margins?

@UselessToucan
Copy link
Contributor Author

For consistency with the player screen. In my opinion, it looks better this way.

@peppy
Copy link
Sponsor Member

peppy commented May 21, 2018 •
edited

let’s not. if you want such consistency the UI should be shared

@UselessToucan
Copy link
Contributor Author

osu_2018-05-21_18-54-08

@peppy peppy merged commit 78ca111 into ppy:master May 25, 2018
@UselessToucan UselessToucan deleted the player_loader_input_toggles branch May 25, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:settings
Projects
None yet
Milestone
Candidate Issues
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@UselessToucan @peppy