Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a hold-to-confirm screen when exiting game using escape key #2514

merged 6 commits into from May 14, 2018


Copy link

@peppy peppy commented May 10, 2018

Resolves #1940.

As this is an alternative implementation, closes #2341.

private Box overlay;

private const int activate_delay = 400;

This comment has been minimized.


huoyaoyuan May 10, 2018

Should this be configurable via virtual?

This comment has been minimized.


peppy May 10, 2018
Author Member

not until we need it. keeping things standardised is best if we can.


protected void BeginConfirm() => overlay.FadeIn(activate_delay, Easing.Out);

This comment has been minimized.


smoogipoo May 10, 2018

.FadeIn().Finally(() => Action?.Invoke())

Wouldn't need the fired bool then.

This comment has been minimized.


peppy May 10, 2018
Author Member

sounds good

peppy added 2 commits May 10, 2018
Anchor = Anchor.Centre,
Origin = Anchor.Centre,
Text = "Aborted!",

This comment has been minimized.


smoogipoo May 14, 2018

Why is this "Aborted!" and not "Fired!"

@smoogipoo smoogipoo merged commit 21ed275 into ppy:master May 14, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
@peppy peppy deleted the peppy:exit-hold-confirmation branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.