Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumb control that follows focus in a screen stack #2521

Merged
merged 15 commits into from May 17, 2018

Conversation

@DrabWeb
Copy link
Member

@DrabWeb DrabWeb commented May 11, 2018

Adds ScreenBreadcrumbControl for navigating a screen stack with breadcrumbs.

@peppy
Copy link
Member

@peppy peppy commented May 11, 2018

I think you need to add some further test steps. This scenario seems wrong:
https://puu.sh/Ak6oX/b2f90ada58.mp4

@DrabWeb DrabWeb force-pushed the DrabWeb:screen-breadcrumbs branch from 9dda28b to fa403e4 May 11, 2018
@peppy peppy added this to the May 2018 milestone May 11, 2018
@peppy peppy added the type:UI label May 11, 2018
public class ScreenBreadcrumbControl<T> : BreadcrumbControl<T> where T : Screen
{
private T currentScreen;
public T CurrentScreen

This comment has been minimized.

@peppy

peppy May 11, 2018
Member

i feel like we want this to be a ctor argument rather than mutable property. would that still work? right now it creates too many weird possibilities since it can be set an any point in execution.

DrabWeb and others added 3 commits May 11, 2018
@peppy
Copy link
Member

@peppy peppy commented May 15, 2018

I rewrote this to use the existing Current bindable more and remove the generic parameter which was never used.

A test still needs to be added for a screen exiting from an external force (currently is not tested).

@peppy peppy force-pushed the DrabWeb:screen-breadcrumbs branch from c9d7ec2 to 28df77e May 15, 2018
peppy and others added 5 commits May 15, 2018
…nto screen-breadcrumbs
This was referenced May 15, 2018
peppy added 2 commits May 16, 2018
@peppy
peppy approved these changes May 17, 2018
@peppy peppy merged commit 5647e53 into ppy:master May 17, 2018
2 checks passed
2 checks passed
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy peppy changed the title Screen breadcrumbs Add breadcrumb control that follows focus in a screen stack May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.