Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd breadcrumb control that follows focus in a screen stack #2521
Conversation
DrabWeb
added some commits
May 11, 2018
This comment has been minimized.
This comment has been minimized.
|
I think you need to add some further test steps. This scenario seems wrong: |
peppy
added this to the May 2018 milestone
May 11, 2018
peppy
added
the
user interface
label
May 11, 2018
| public class ScreenBreadcrumbControl<T> : BreadcrumbControl<T> where T : Screen | ||
| { | ||
| private T currentScreen; | ||
| public T CurrentScreen |
This comment has been minimized.
This comment has been minimized.
peppy
May 11, 2018
Member
i feel like we want this to be a ctor argument rather than mutable property. would that still work? right now it creates too many weird possibilities since it can be set an any point in execution.
DrabWeb
and others
added some commits
May 11, 2018
This comment has been minimized.
This comment has been minimized.
|
I rewrote this to use the existing A test still needs to be added for a screen exiting from an external force (currently is not tested). |
peppy
and others
added some commits
May 15, 2018
This was referenced May 15, 2018
Closed
peppy
added some commits
May 16, 2018
peppy
merged commit 5647e53
into
ppy:master
May 17, 2018
peppy
changed the title from
Screen breadcrumbs
to
Add breadcrumb control that follows focus in a screen stack
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
DrabWeb commentedMay 11, 2018
•
edited
Adds
ScreenBreadcrumbControlfor navigating a screen stack with breadcrumbs.