Add breadcrumb control that follows focus in a screen stack #2521
Conversation
|
I think you need to add some further test steps. This scenario seems wrong: |
| public class ScreenBreadcrumbControl<T> : BreadcrumbControl<T> where T : Screen | ||
| { | ||
| private T currentScreen; | ||
| public T CurrentScreen |
peppy
May 11, 2018
Member
i feel like we want this to be a ctor argument rather than mutable property. would that still work? right now it creates too many weird possibilities since it can be set an any point in execution.
i feel like we want this to be a ctor argument rather than mutable property. would that still work? right now it creates too many weird possibilities since it can be set an any point in execution.
|
I rewrote this to use the existing A test still needs to be added for a screen exiting from an external force (currently is not tested). |
This was referenced May 15, 2018
Closed
peppy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Adds
ScreenBreadcrumbControlfor navigating a screen stack with breadcrumbs.