Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrawableRoom improvements #2522

Merged
merged 7 commits into from May 21, 2018

Conversation

2 participants
@DrabWeb
Copy link
Contributor

DrabWeb commented May 11, 2018

  • Create draw hierarchy in load.
  • Remove all the private display* methods.
  • Add selection.

@peppy peppy added this to the May 2018 milestone May 11, 2018

@peppy

This comment has been minimized.

Copy link
Member

peppy commented May 11, 2018

How come there's no input logic here? Is that in a subsequent PR? I think it may be best to include that here if possible so the panels can be "selected" by clicking them in the test case.

@peppy

peppy approved these changes May 21, 2018

@peppy peppy merged commit 4163564 into ppy:master May 21, 2018

2 checks passed

CodeFactor 1 issue fixed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.