Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use osu!stable hitwindows for converted hitobjects #2524

Merged
merged 13 commits into from May 15, 2018

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 11, 2018

For difficulty/performance calculation purposes, we'll want to use osu!stable's hitwindows.

@smoogipoo smoogipoo added this to the May 2018 milestone May 11, 2018
hitWindows = null;
if (HitWindows == null)
HitWindows = CreateHitWindows();
HitWindows?.SetDifficulty(difficulty.OverallDifficulty);
Copy link
Member

@peppy peppy May 11, 2018

should CreateHitWindows actually return null?

Copy link
Contributor Author

@smoogipoo smoogipoo May 11, 2018

Good point. HitWindows can/should be nullable though (catch).

peppy
peppy approved these changes May 15, 2018
@peppy peppy merged commit d7d3838 into ppy:master May 15, 2018
2 checks passed
@smoogipoo smoogipoo deleted the convert-object-hitwindows branch Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants