Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix osu! difficulty/performance calculation failing or giving wrong values #2525

merged 6 commits into from May 12, 2018


Copy link

@smoogipoo smoogipoo commented May 11, 2018

In replay.

@smoogipoo smoogipoo added this to the May 2018 milestone May 11, 2018
@@ -32,7 +32,7 @@ public OsuPerformanceCalculator(Ruleset ruleset, IBeatmap beatmap, Score score)
countHitCircles = Beatmap.HitObjects.Count(h => h is HitCircle);

beatmapMaxCombo = Beatmap.HitObjects.Count();
beatmapMaxCombo += Beatmap.HitObjects.OfType<Slider>().Sum(s => s.NestedHitObjects.Count) + 1;
beatmapMaxCombo += Beatmap.HitObjects.OfType<Slider>().Count();

This comment was marked as off-topic.

@peppy peppy merged commit 4c55b90 into ppy:master May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants