New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix osu! difficulty/performance calculation failing or giving wrong values #2525

Merged
merged 6 commits into from May 12, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented May 11, 2018

In replay.

@smoogipoo smoogipoo added this to the May 2018 milestone May 11, 2018

@@ -32,7 +32,7 @@ public OsuPerformanceCalculator(Ruleset ruleset, IBeatmap beatmap, Score score)
countHitCircles = Beatmap.HitObjects.Count(h => h is HitCircle);
beatmapMaxCombo = Beatmap.HitObjects.Count();
beatmapMaxCombo += Beatmap.HitObjects.OfType<Slider>().Sum(s => s.NestedHitObjects.Count) + 1;
beatmapMaxCombo += Beatmap.HitObjects.OfType<Slider>().Count();

This comment has been minimized.

@peppy

peppy May 11, 2018

Member

this doesn't look right... let's double-check the corresponding code in osu-stable/osu-performance.

@smoogipoo smoogipoo referenced this pull request May 11, 2018

Merged

Implement a CLI performance calculator #1

2 of 2 tasks complete

@peppy peppy added the compatibility label May 12, 2018

@peppy

peppy approved these changes May 12, 2018

@peppy peppy merged commit 4c55b90 into ppy:master May 12, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment