Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global key bindings for changing current ruleset #2532

Merged
merged 10 commits into from May 21, 2018

Conversation

ocboogie
Copy link
Contributor

@ocboogie ocboogie commented May 12, 2018

Resolves #2509
Old pr #2513
https://youtu.be/eHtNzSfpzZk

Note: the crash from changing the rule set on the home screen is not a result of this change. Also that might only be happening to me

@peppy
Copy link
Member

peppy commented May 14, 2018

The crash you mention is fixed by #2533.

@peppy
Copy link
Member

peppy commented May 14, 2018

This is a really convoluted way of doing this. Why not just use OnKeyDown?

@ocboogie
Copy link
Contributor Author

ocboogie commented May 14, 2018

@peppy Yeah sorry I'm still trying to get familiar with this code base. I for some reason thought that OnKeyDown only work if the Drawable had focus.
But anyways this should be better.

@peppy
Copy link
Member

peppy commented May 21, 2018

I've made some large changes to the code to bring this up-to-par. @ocboogie please have a look and see what was required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants