Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd global key bindings for changing current ruleset #2532
Conversation
ocboogie
added some commits
May 12, 2018
This comment has been minimized.
This comment has been minimized.
|
The crash you mention is fixed by #2533. |
This comment has been minimized.
This comment has been minimized.
|
This is a really convoluted way of doing this. Why not just use |
peppy
added
the
resolves issue
label
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
@peppy Yeah sorry I'm still trying to get familiar with this code base. I for some reason thought that |
ocboogie
and others
added some commits
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
I've made some large changes to the code to bring this up-to-par. @ocboogie please have a look and see what was required. |
peppy
referenced this pull request
May 21, 2018
Closed
Add global key bindings for changing current game mode #2513
peppy
merged commit 1eb465b
into
ppy:master
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ocboogie commentedMay 12, 2018
•
edited
Resolves #2509
Old pr #2513
https://youtu.be/eHtNzSfpzZk
Note: the crash from changing the rule set on the home screen is not a result of this change. Also that might only be happening to me