New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global key bindings for changing current ruleset #2532

Merged
merged 10 commits into from May 21, 2018

Conversation

2 participants
@ocboogie
Contributor

ocboogie commented May 12, 2018

Resolves #2509
Old pr #2513
https://youtu.be/eHtNzSfpzZk

Note: the crash from changing the rule set on the home screen is not a result of this change. Also that might only be happening to me

ocboogie added some commits May 12, 2018

@peppy

This comment has been minimized.

Member

peppy commented May 14, 2018

The crash you mention is fixed by #2533.

@peppy

This comment has been minimized.

Member

peppy commented May 14, 2018

This is a really convoluted way of doing this. Why not just use OnKeyDown?

@ocboogie

This comment has been minimized.

Contributor

ocboogie commented May 14, 2018

@peppy Yeah sorry I'm still trying to get familiar with this code base. I for some reason thought that OnKeyDown only work if the Drawable had focus.
But anyways this should be better.

ocboogie and others added some commits May 14, 2018

Rewrite code for clarity
This also uses the AvailableRulesets list rather than private IDs
@peppy

This comment has been minimized.

Member

peppy commented May 21, 2018

I've made some large changes to the code to bring this up-to-par. @ocboogie please have a look and see what was required.

@peppy

peppy approved these changes May 21, 2018

@peppy peppy merged commit 1eb465b into ppy:master May 21, 2018

2 checks passed

CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment