New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global key bindings for changing current ruleset #2532
Conversation
The crash you mention is fixed by #2533. |
This is a really convoluted way of doing this. Why not just use |
@peppy Yeah sorry I'm still trying to get familiar with this code base. I for some reason thought that |
This also uses the AvailableRulesets list rather than private IDs
I've made some large changes to the code to bring this up-to-par. @ocboogie please have a look and see what was required. |
Resolves #2509
Old pr #2513
https://youtu.be/eHtNzSfpzZk
Note: the crash from changing the rule set on the home screen is not a result of this change. Also that might only be happening to me