Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance calculation not considering time-adjustment mods #2538

Merged
merged 5 commits into from May 14, 2018

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 14, 2018

Tested with Cookiezi's score on https://osu.ppy.sh/b/774965?m=0.

The beatmap aim difficulty is still off a little bit causing the final pp value to be off, but it's around 832pp (lazer) vs 817pp (web).

Verified AR/OD values against provided database values.

@smoogipoo smoogipoo added this to the May 2018 milestone May 14, 2018
@smoogipoo smoogipoo force-pushed the smoogipoo:fix-diffcalc-timerates branch from a29e260 to a819211 May 14, 2018
@peppy
peppy approved these changes May 14, 2018
peppy added 2 commits May 14, 2018
@peppy peppy merged commit 1045199 into ppy:master May 14, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:fix-diffcalc-timerates branch Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants