Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drumroll completions always giving GREAT judgements #2539

merged 2 commits into from May 14, 2018


Copy link

Due to RequiredGoodHits/RequiredGreatHits being calculated prior to ticks being generated.

Due to requiredgoodhits/requiredgreathits being calculated prior to nested hitobjects.
@peppy peppy merged commit 92c9c2d into ppy:master May 14, 2018
@smoogipoo smoogipoo deleted the fix-drumroll-judgements branch June 15, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants