New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleted beatmaps still being accessible in MusicController #2543

Merged
merged 4 commits into from May 15, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented May 14, 2018

Fixes #2511.

PlaylistOverlay isn't present so it doesn't update its beatmap sets list when beatmaps are added/removed because the scheduler doesn't run.

This moves all handling of beatmap sets to MusicController, which is where it should've been anyway. PlaylistOverlay now exposes OrderChanged to signal MusicController to change the ordering of its list.

Cleans up a lot in the process.

@peppy

peppy approved these changes May 15, 2018

@peppy peppy merged commit f3d3d77 into ppy:master May 15, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:beatmap-delete-fix branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment