Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subclasses of LegacyScoreParser to specify beatmap/ruleset retrieval #2551

merged 4 commits into from May 15, 2018


Copy link

Used for PerformanceCalculator osu!tool, which now doesn't use BeatmapManager/RulesetStore.

peppy previously approved these changes May 15, 2018
@@ -25,6 +25,10 @@ public LegacyScoreParser(RulesetStore rulesets, BeatmapManager beatmaps)
this.beatmaps = beatmaps;

protected LegacyScoreParser()

This comment was marked as off-topic.

@peppy peppy merged commit b40c558 into ppy:master May 15, 2018
@smoogipoo smoogipoo deleted the score-parser-deriving branch June 15, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants