Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subclasses of LegacyScoreParser to specify beatmap/ruleset retrieval #2551

Merged
merged 4 commits into from May 15, 2018

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 15, 2018

Used for PerformanceCalculator osu!tool, which now doesn't use BeatmapManager/RulesetStore.

@smoogipoo smoogipoo added this to the May 2018 milestone May 15, 2018
@@ -25,6 +25,10 @@ public LegacyScoreParser(RulesetStore rulesets, BeatmapManager beatmaps)
this.beatmaps = beatmaps;
}

protected LegacyScoreParser()

This comment has been minimized.

@peppy

peppy May 15, 2018
Member

not sure how safe this is. even though this is a legacy class, may be worth making a base abstract class to avoid confusion?

right now it's not enforced that a consumer must override GetRuleset/GetBeatmap if they derive the class.

@peppy
peppy approved these changes May 15, 2018
@peppy peppy merged commit b40c558 into ppy:master May 15, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:score-parser-deriving branch Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants