Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring osu! difficulty calculation on par with osu!stable #2556

Merged
merged 8 commits into from May 15, 2018

Conversation

3 participants
@smoogipoo
Copy link
Contributor

smoogipoo commented May 15, 2018

Tested on the following plays by Cookiezi:

Beatmap Mods Expected (pp) Actual (pp)
129891 HD, HR 819.692 819.719
774965 HD, DT 775.99 776.085
658127 HD, HR 741.929 742.072
999944 HD, DT 705.393 705.429

The remaining difference is due to the end of sliders being wangjangled to be 36ms earlier on stable.

@smoogipoo smoogipoo added this to the May 2018 milestone May 15, 2018

@smoogipoo

This comment has been minimized.

Copy link
Contributor Author

smoogipoo commented May 15, 2018

We may want to re-implement the triangle stuff in the future, or something similar, along with the "reading strain" part. But since it wasn't even utilised I see no reason to keep it - just simplifying code.

@smoogipoo smoogipoo force-pushed the smoogipoo:more-diffcalc-improvements branch from 5922d5b to cf08293 May 15, 2018

@@ -21,8 +21,8 @@ public void ApplyToDifficulty(BeatmapDifficulty difficulty)
const float ratio = 1.4f;
difficulty.CircleSize *= 1.3f; // CS uses a custom 1.3 ratio.

This comment has been minimized.

@Tom94

Tom94 May 15, 2018

Contributor

Is this not capped at 10?

This comment has been minimized.

@smoogipoo

smoogipoo May 15, 2018

Author Contributor

Just checked - should be, good catch.

@peppy

peppy approved these changes May 15, 2018

@peppy peppy merged commit 07e00fb into ppy:master May 15, 2018

1 of 2 checks passed

CodeFactor 1 issue found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo added the osu! label May 16, 2018

@smoogipoo smoogipoo deleted the smoogipoo:more-diffcalc-improvements branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.