New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplayer base screen #2560

Merged
merged 7 commits into from May 17, 2018

Conversation

3 participants
@DrabWeb
Contributor

DrabWeb commented May 16, 2018

Currently only uses the placeholder whitebox screens, so the display names in the header are off.

@peppy peppy added the online / API label May 16, 2018

@peppy peppy added this to the May 2018 milestone May 16, 2018

DrabWeb and others added some commits May 17, 2018

},
};
breadcrumbs.OnLoadComplete = d => breadcrumbs.AccentColour = Color4.White;

This comment has been minimized.

@peppy

peppy May 17, 2018

Member

shouldn't do this. needs to be subclassed instead

This comment has been minimized.

@smoogipoo

smoogipoo May 17, 2018

Contributor

Or should allow setting the colour prior to load().

This comment has been minimized.

@peppy

peppy May 17, 2018

Member

Probably. but framework so for another day...

@peppy

peppy approved these changes May 17, 2018

@peppy peppy merged commit f755ea5 into ppy:master May 17, 2018

2 checks passed

CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment