Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hold notes never expiring #2564

Merged
merged 2 commits into from May 17, 2018
Merged

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 16, 2018

In combination with ppy/osu-framework#1554 (not a prerequisite), every time a judgement happened all hold notes would refresh both BufferedContainers.

@peppy
peppy approved these changes May 17, 2018
@peppy peppy merged commit 0d9518c into ppy:master May 17, 2018
2 checks passed
2 checks passed
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy peppy changed the title Fix hold notes never dying Fix hold notes never expiring May 17, 2018
@smoogipoo smoogipoo deleted the smoogipoo:mania-performance-improvements branch Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants