Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up beatmap parsing and conversion #2566

Merged
merged 3 commits into from May 17, 2018

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 17, 2018

Speeds up difficulty calculation by 3x (45sec -> 15sec for ~600 beatmaps, no-mod).

@smoogipoo smoogipoo force-pushed the smoogipoo:beatmap-parsing-performance branch from 3e49601 to 397d936 May 17, 2018
@smoogipoo smoogipoo removed the blocked label May 17, 2018
@peppy
peppy approved these changes May 17, 2018
@peppy peppy changed the title Speed up beatmap parsing/conversion Speed up beatmap parsing andconversion May 17, 2018
@peppy peppy changed the title Speed up beatmap parsing andconversion Speed up beatmap parsing and conversion May 17, 2018
@peppy peppy merged commit 9e7728d into ppy:master May 17, 2018
2 checks passed
2 checks passed
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:beatmap-parsing-performance branch Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants