New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix taiko slider multiplier being applied twice #2568

Merged
merged 3 commits into from May 18, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented May 17, 2018

The previous code (397d936#diff-bb91a927383b6458b59e4536e8d51c27L54-L55) updated a cloned difficulty but then didn't do anything with it.

This is actually broken. The previous PR fixed it by actually modifying the difficulty, but broke this along the way.

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented May 17, 2018

Taiko's beatmap conversion tests are currently ignored :(

@peppy

peppy approved these changes May 18, 2018

@peppy peppy merged commit cebc0fc into ppy:master May 18, 2018

2 checks passed

CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:fix-taiko-slider-multiplier branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment