Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix taiko slider multiplier being applied twice #2568
Conversation
smoogipoo
added
osu!taiko
regression
beatmap conversion
labels
May 17, 2018
smoogipoo
added this to the May 2018 milestone
May 17, 2018
This comment has been minimized.
This comment has been minimized.
|
Taiko's beatmap conversion tests are currently ignored :( |
smoogipoo
referenced this pull request
May 17, 2018
Open
Taiko doesn't correctly convert drum rolls for some beatmaps #2141
peppy
merged commit cebc0fc
into
ppy:master
May 18, 2018
smoogipoo
deleted the
smoogipoo:fix-taiko-slider-multiplier
branch
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
smoogipoo commentedMay 17, 2018
The previous code (397d936#diff-bb91a927383b6458b59e4536e8d51c27L54-L55) updated a cloned difficulty but then didn't do anything with it.
This is actually broken. The previous PR fixed it by actually modifying the difficulty, but broke this along the way.