Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix taiko slider multiplier being applied twice #2568

Merged
merged 3 commits into from May 18, 2018

Conversation

smoogipoo
Copy link
Contributor

The previous code (397d936#diff-bb91a927383b6458b59e4536e8d51c27L54-L55) updated a cloned difficulty but then didn't do anything with it.

This is actually broken. The previous PR fixed it by actually modifying the difficulty, but broke this along the way.

@smoogipoo
Copy link
Contributor Author

Taiko's beatmap conversion tests are currently ignored :(

@peppy peppy merged commit cebc0fc into ppy:master May 18, 2018
@smoogipoo smoogipoo deleted the fix-taiko-slider-multiplier branch June 15, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants