Fix taiko slider multiplier being applied twice #2568
Merged
Conversation
|
Taiko's beatmap conversion tests are currently ignored :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The previous code (397d936#diff-bb91a927383b6458b59e4536e8d51c27L54-L55) updated a cloned difficulty but then didn't do anything with it.
This is actually broken. The previous PR fixed it by actually modifying the difficulty, but broke this along the way.