Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement taiko performance calculation #2572

Merged
merged 3 commits into from May 18, 2018

Conversation

2 participants
@smoogipoo
Copy link
Contributor

smoogipoo commented May 17, 2018

Tested against https://osu.ppy.sh/b/1413771

Mods Expected (Strain) Actual (Strain) Expected (pp) Actual (pp)
None 7.976 7.976 458.361 458.361
DT 10.024 10.024 708.853 708.856
DT, HR 10.024 10.024 - -

Not sure why the actual pp is different from the expected value in the DT row, but it's not of big significance.

@smoogipoo smoogipoo added this to the May 2018 milestone May 17, 2018

@smoogipoo

This comment has been minimized.

Copy link
Contributor Author

smoogipoo commented May 17, 2018

Will only be accurate for taiko-specific beatmaps, due to aforementioned conversion issues... #2141 (comment)

@smoogipoo smoogipoo force-pushed the smoogipoo:taiko-performance-calculator branch from 70ca0bc to 3091d3a May 17, 2018

@peppy

peppy approved these changes May 18, 2018

@peppy peppy merged commit ce9bfcc into ppy:master May 18, 2018

2 checks passed

CodeFactor 1 issue fixed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:taiko-performance-calculator branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.