Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overlays from showing in intro/outro sequences #2577

Merged
merged 6 commits into from May 21, 2018

Conversation

Aergwyn
Copy link
Member

@Aergwyn Aergwyn commented May 18, 2018

closes #2461

An alternative I found would be to add it right in OsuGame.OnPressed but that would basically stop all global keybinds...

@peppy
Copy link
Sponsor Member

peppy commented May 20, 2018

This stops overlays from being shown in many other screens (due to the interaction with ShowOverlaysOnEnter).

Also let's rename all instances of ShowOverlays to AllowOverlays and ShowOverlaysOnEnter to HideOverlaysOnEnter (requires logic inversion).

Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as proposed

ShowOverlays -> AllowOverlays
ShowOverlaysOnEnter -> HideOverlaysOnEnter
@Aergwyn
Copy link
Member Author

Aergwyn commented May 21, 2018

In which screens is it supposed to show them which they aren't?
With this change HideOverlaysOnEnter => true prevents them to open as long as you are on the screen.
Was it supposed to only close them on entering/resuming once? I'm a bit confused what seems to be wrong.

@peppy
Copy link
Sponsor Member

peppy commented May 21, 2018

The only screens which should completely disallow overlays should be the intro/outro. All others should be unaffected by your PR (currently it's applying to all screens which override that property).

@Aergwyn Aergwyn force-pushed the respect-showoverlay-bindable branch from 24a459a to b7e3ea3 Compare May 21, 2018 13:54
@peppy peppy changed the title Prevent Overlays from showing in intro/outro sequences Prevent overlays from showing in intro/outro sequences May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlays are openable during intro and exit transitions
2 participants