New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overlays from showing in intro/outro sequences #2577

Merged
merged 6 commits into from May 21, 2018

Conversation

2 participants
@Aergwyn
Member

Aergwyn commented May 18, 2018

closes #2461

An alternative I found would be to add it right in OsuGame.OnPressed but that would basically stop all global keybinds...

@peppy

This comment has been minimized.

Member

peppy commented May 20, 2018

This stops overlays from being shown in many other screens (due to the interaction with ShowOverlaysOnEnter).

Also let's rename all instances of ShowOverlays to AllowOverlays and ShowOverlaysOnEnter to HideOverlaysOnEnter (requires logic inversion).

@peppy

as proposed

Rename for better understanding
ShowOverlays -> AllowOverlays
ShowOverlaysOnEnter -> HideOverlaysOnEnter
@Aergwyn

This comment has been minimized.

Member

Aergwyn commented May 21, 2018

In which screens is it supposed to show them which they aren't?
With this change HideOverlaysOnEnter => true prevents them to open as long as you are on the screen.
Was it supposed to only close them on entering/resuming once? I'm a bit confused what seems to be wrong.

@peppy

This comment has been minimized.

Member

peppy commented May 21, 2018

The only screens which should completely disallow overlays should be the intro/outro. All others should be unaffected by your PR (currently it's applying to all screens which override that property).

@peppy peppy changed the title from Prevent Overlays from showing in intro/outro sequences to Prevent overlays from showing in intro/outro sequences May 21, 2018

@peppy

peppy approved these changes May 21, 2018

@peppy peppy merged commit 9b307f0 into ppy:master May 21, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
CodeFactor No issues found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment