Prevent overlays from showing in intro/outro sequences #2577
Conversation
This stops overlays from being shown in many other screens (due to the interaction with Also let's rename all instances of |
as proposed |
ShowOverlays -> AllowOverlays ShowOverlaysOnEnter -> HideOverlaysOnEnter
In which screens is it supposed to show them which they aren't? |
The only screens which should completely disallow overlays should be the intro/outro. All others should be unaffected by your PR (currently it's applying to all screens which override that property). |
24a459a
to
b7e3ea3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
closes #2461
An alternative I found would be to add it right in
OsuGame.OnPressed
but that would basically stop all global keybinds...