New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double-HR application in OsuDifficultyCalculator #2587

Merged
merged 2 commits into from May 25, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented May 19, 2018

HR now applies to AR through the mod, this would doubly-apply the scaling factor.

There still seems to be an issue with HR, it looks like perhaps the coordinates aren't getting inverted correctly. Will look into that a bit later. Still brings calculations closer in-line.

@smoogipoo smoogipoo added this to the May 2018 milestone May 19, 2018

@@ -105,7 +105,7 @@ private double computeStrainValue()
private double computeAccuracyValue(double strainValue)
{
double hitWindowGreat = (Beatmap.HitObjects.First().HitWindows.Great / 2 - 0.5) / TimeRate;

This comment has been minimized.

@peppy

peppy May 19, 2018

Member

have you double-checked this against stable and made sure this is correct?

This comment has been minimized.

@smoogipoo

smoogipoo May 19, 2018

Contributor

On a double check, headless and master differ in this. Headless has the 0.5 offsets whereas master doesn't so we may want to keep them...

@peppy

peppy approved these changes May 25, 2018

@peppy peppy merged commit e62718f into ppy:master May 25, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:diffcalc-double-hr branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment