New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow drag clicking footer and filter on song select #2594

Merged
merged 1 commit into from May 21, 2018

Conversation

2 participants
@Joehuu
Contributor

Joehuu commented May 21, 2018

This is the correct input behavior for mostly everything that is not a scroll container.
The buttons will activate when releasing anywhere inside the button if you previously click and drag. The previous behavior was that you have to release it near the area you clicked on.

Same behavior as the leaderboard filter which was already fine.

Don't know this but isn't OnDragStart only used on scroll containers or the like?

@peppy peppy added this to the May 2018 milestone May 21, 2018

@peppy

peppy approved these changes May 21, 2018

@peppy peppy merged commit dc10273 into ppy:master May 21, 2018

2 checks passed

CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Joehuu Joehuu deleted the Joehuu:drag-clicking branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment