Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selecting song in playlist not starting the audio #2622

Merged
merged 2 commits into from May 27, 2018

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 23, 2018

Fixes #2620.

Basically same thing that's done in MusicController.next() and MusicController.prev().

@smoogipoo smoogipoo added this to the May 2018 milestone May 23, 2018
@UselessToucan
Copy link
Contributor

@UselessToucan UselessToucan commented May 24, 2018

I suggest to call Restart inside of the beatmapBacking.ValueChanged handler.

@peppy peppy removed this from the May 2018 milestone May 25, 2018
@peppy
Copy link
Member

@peppy peppy commented May 27, 2018

@UselessToucan that's not always what we want, for instance in the editor where playback shouldn't immediately start. I think this is fine for now.

@peppy
peppy approved these changes May 27, 2018
@peppy peppy merged commit 9abde7e into ppy:master May 27, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:fix-playlist-pause branch Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants