New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect default values keeping overlays in wrong state #2624

Merged
merged 1 commit into from May 24, 2018

Conversation

2 participants
@Aergwyn
Member

Aergwyn commented May 23, 2018

Using the same Bindables as the default value that are bound to the current state cause it to never change if it's not overridden.
Decoupling this lets it revert back to its default whenever it was intended to be: like leaving gameplay.

fixes #2619

@peppy peppy added this to the May 2018 milestone May 24, 2018

@peppy

peppy approved these changes May 24, 2018

@peppy peppy merged commit 6d6cea1 into ppy:master May 24, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Aergwyn Aergwyn deleted the Aergwyn:hide-toolbar-after-play branch May 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment