Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix incorrect default values keeping overlays in wrong state #2624
Conversation
peppy
added
regression
user interface
labels
May 24, 2018
peppy
added this to the May 2018 milestone
May 24, 2018
peppy
merged commit 6d6cea1
into
ppy:master
May 24, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
Aergwyn
deleted the
Aergwyn:hide-toolbar-after-play
branch
May 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Aergwyn commentedMay 23, 2018
Using the same Bindables as the default value that are bound to the current state cause it to never change if it's not overridden.
Decoupling this lets it revert back to its default whenever it was intended to be: like leaving gameplay.
fixes #2619