Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix catch sizing #2632

Merged
merged 6 commits into from May 31, 2018
Merged

Fix catch sizing #2632

merged 6 commits into from May 31, 2018

Conversation

@peppy
Copy link
Member

@peppy peppy commented May 25, 2018

  • Fixes catcher size
  • Reduces fruit sizes
  • Makes it easier to scale
  • Adjusts the vertical position of the catcher (aka playfield scale) to match stable

Resolves #2063.

public CatcherSprite()
{
Size = new Vector2(CATCHER_SIZE);
FillMode = FillMode.Fill;

This comment has been minimized.

@smoogipoo

smoogipoo May 28, 2018
Contributor

Are you sure this is implemented correctly? Fillmodes do nothing without relative size.

This comment has been minimized.

@smoogipoo

smoogipoo May 28, 2018
Contributor

I mean the old code had the same issue but you should look into it because this is probably not intended.

This comment has been minimized.

@peppy

peppy May 28, 2018
Author Member

Last I checked it was working as expected.

This comment has been minimized.

@smoogipoo

smoogipoo May 31, 2018
Contributor

So I guess this is not being looked at further. I'm going to go ahead and merge this because the previous implementation had the same issue as far as I can see.

@peppy
Copy link
Member Author

@peppy peppy commented May 31, 2018

As this is June milestone I haven't yet checked into it. I will look at it before it is merged. Don't merge yet (and please check the may milestone PRs first).

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 31, 2018

This is happening within the next 2 minutes.

@peppy
Copy link
Member Author

@peppy peppy commented May 31, 2018

Should be good to go

@smoogipoo smoogipoo merged commit 1201fe9 into ppy:master May 31, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy peppy deleted the peppy:catch-sizing-fixes branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants