Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix catch sizing #2632

Merged
merged 6 commits into from May 31, 2018
Merged

Fix catch sizing #2632

merged 6 commits into from May 31, 2018

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented May 25, 2018 •
edited

  • Fixes catcher size
  • Reduces fruit sizes
  • Makes it easier to scale
  • Adjusts the vertical position of the catcher (aka playfield scale) to match stable

Resolves #2063.

@peppy peppy modified the milestones: May 2018, June 2018 May 25, 2018
@peppy peppy removed this from the June 2018 milestone May 26, 2018
smoogipoo
smoogipoo reviewed May 28, 2018
View reviewed changes
osu.Game.Rulesets.Catch/UI/CatcherArea.cs Outdated
public CatcherSprite()
{
Size = new Vector2(CATCHER_SIZE);
FillMode = FillMode.Fill;

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

smoogipoo
smoogipoo previously approved these changes May 31, 2018
View reviewed changes
@peppy
Copy link
Sponsor Member Author

peppy commented May 31, 2018

As this is June milestone I haven't yet checked into it. I will look at it before it is merged. Don't merge yet (and please check the may milestone PRs first).

@smoogipoo
Copy link
Contributor

This is happening within the next 2 minutes.

@peppy
Copy link
Sponsor Member Author

peppy commented May 31, 2018

Should be good to go

@smoogipoo smoogipoo merged commit 1201fe9 into ppy:master May 31, 2018
@peppy peppy deleted the catch-sizing-fixes branch June 21, 2018 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peppy @smoogipoo