Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quit button test occasionally failing #2633

Merged
merged 2 commits into from May 26, 2018
Merged

Conversation

@peppy
Copy link
Member

@peppy peppy commented May 25, 2018

No description provided.

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 25, 2018

Solution to fix a failing test is to remove the test? Nope.

Attach a local decoupleable framed clock to the hierarchy instead.

@peppy
Copy link
Member Author

@peppy peppy commented May 25, 2018

The test was pointless, just a remnant of the previous owner of the code.

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 25, 2018

Pointless how? Because it was a simple scenario that you could think of off the top of your head? What if the logic is changed incorrectly in the future?

@peppy
Copy link
Member Author

@peppy peppy commented May 25, 2018

We can't start testing every transform sequence every instance it is present. It would get completely redundant. Have to focus on actual interaction tests.

@smoogipoo smoogipoo merged commit a87c260 into ppy:master May 26, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy peppy deleted the peppy:fix-failing-tests branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.