Fix quit button test occasionally failing #2633
Merged
Conversation
Solution to fix a failing test is to remove the test? Nope. Attach a local decoupleable framed clock to the hierarchy instead. |
The test was pointless, just a remnant of the previous owner of the code. |
Pointless how? Because it was a simple scenario that you could think of off the top of your head? What if the logic is changed incorrectly in the future? |
We can't start testing every transform sequence every instance it is present. It would get completely redundant. Have to focus on actual interaction tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.