Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix results screen parallax being cut off #2663
Conversation
smoogipoo
added
bug
design
labels
May 28, 2018
smoogipoo
modified the milestones:
June 2018,
May 2018
May 28, 2018
smoogipoo
assigned
peppy
May 28, 2018
peppy
merged commit e8cc329
into
ppy:master
May 30, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
smoogipoo
deleted the
smoogipoo:fix-results-parallax
branch
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
smoogipoo commentedMay 28, 2018
Alternative to / closes #2549.
Didn't want to reference the toolbar as was done, also wanted to remove the awkward scaling factors so rather than scaling down the inner one, we scale up the outer one.