Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix beatmap importing entering a bad state #2665
Conversation
peppy
added
database
import
labels
May 28, 2018
peppy
added this to the May 2018 milestone
May 29, 2018
peppy
added some commits
May 28, 2018
peppy
referenced this pull request
May 29, 2018
Merged
Fix conflicting Hash and Online IDs on beatmap import #2673
peppy
added some commits
May 29, 2018
peppy
added
the
resolves issue
label
May 30, 2018
peppy
removed this from the May 2018 milestone
May 30, 2018
smoogipoo
merged commit 3fc2bfd
into
ppy:master
May 31, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
peppy
deleted the
peppy:import-fixes
branch
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
peppy commentedMay 28, 2018
•
edited
Previously a single failed import would cause all further imports to fail.
This doesn't fix the remaining known cause of imports failing, which will be addressed in a separate PR. Adds back transaction support, with accompanying EF updates to support transactions correctly.
Note that I had to restructure transactions a bit as EF doesn't allow nested transactions. Now there is a write context which becomes transaction "leader" which is performing the commit.
Partly addresses #2236