Fix beatmap importing entering a bad state #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like transactions are used internally during migration.
A remove event should not be fired before the update is successful.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a single failed import would cause all further imports to fail.
This doesn't fix the remaining known cause of imports failing, which will be addressed in a separate PR. Adds back transaction support, with accompanying EF updates to support transactions correctly.
Note that I had to restructure transactions a bit as EF doesn't allow nested transactions. Now there is a write context which becomes transaction "leader" which is performing the commit.
Partly addresses #2236