Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beatmap importing entering a bad state #2665

merged 17 commits into from May 31, 2018


Copy link

@peppy peppy commented May 28, 2018

Previously a single failed import would cause all further imports to fail.

This doesn't fix the remaining known cause of imports failing, which will be addressed in a separate PR. Adds back transaction support, with accompanying EF updates to support transactions correctly.

Note that I had to restructure transactions a bit as EF doesn't allow nested transactions. Now there is a write context which becomes transaction "leader" which is performing the commit.

Partly addresses #2236

@peppy peppy added this to the May 2018 milestone May 29, 2018
@peppy peppy force-pushed the peppy:import-fixes branch from 1c0888d to c1f416b May 29, 2018
@peppy peppy mentioned this pull request May 29, 2018
1 of 1 task complete
@peppy peppy removed this from the May 2018 milestone May 30, 2018
Copy link

@smoogipoo smoogipoo left a comment

Looks fine to me.

@smoogipoo smoogipoo merged commit 3fc2bfd into ppy:master May 31, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
@peppy peppy deleted the peppy:import-fixes branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants