Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCentralise beatmap set cover update logic #2667
Conversation
DrabWeb
added some commits
May 28, 2018
peppy
added
the
code quality
label
May 29, 2018
peppy
added this to the June 2018 milestone
May 29, 2018
DrabWeb
referenced this pull request
May 29, 2018
Merged
Multiplayer shared logic encapsulation #2669
| private void updateCover() | ||
| { | ||
| displayedCover?.FadeOut(400); | ||
| displayedCover?.Expire(); |
This comment has been minimized.
This comment has been minimized.
| @@ -63,7 +62,7 @@ private void updateDisplay() | ||
| artist.Text = BeatmapSet?.Metadata.Artist ?? string.Empty; | ||
| onlineStatusPill.Status = BeatmapSet?.OnlineInfo.Status ?? BeatmapSetOnlineStatus.None; | ||
| cover?.FadeOut(400, Easing.Out); | ||
| cover.BeatmapSet = null; |
This comment has been minimized.
This comment has been minimized.
peppy
added
the
pending review
label
Jun 1, 2018
peppy
changed the title from
Updateable beatmap set cover
to
Centralise beatmap set cover update logic
Jun 1, 2018
peppy
merged commit 03cc4e8
into
ppy:master
Jun 1, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
DrabWeb commentedMay 28, 2018
This logic was copy pasted everywhere, so I put it into a
UpdateableBeatmapSetCoverclass. Functions similar toUpdateableAvatar.