Centralise beatmap set cover update logic #2667
Merged
Conversation
| private void updateCover() | ||
| { | ||
| displayedCover?.FadeOut(400); | ||
| displayedCover?.Expire(); |
peppy
May 31, 2018
Member
probably best to set this to null here.
probably best to set this to null here.
| @@ -63,7 +62,7 @@ private void updateDisplay() | |||
| artist.Text = BeatmapSet?.Metadata.Artist ?? string.Empty; | |||
| onlineStatusPill.Status = BeatmapSet?.OnlineInfo.Status ?? BeatmapSetOnlineStatus.None; | |||
|
|
|||
| cover?.FadeOut(400, Easing.Out); | |||
| cover.BeatmapSet = null; | |||
peppy
May 31, 2018
Member
cover.BeatmapSet = BeatmapSet;
and remove the line below.
cover.BeatmapSet = BeatmapSet;
and remove the line below.
|
nice job |
peppy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This logic was copy pasted everywhere, so I put it into a
UpdateableBeatmapSetCoverclass. Functions similar toUpdateableAvatar.