New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralise beatmap set cover update logic #2667

Merged
merged 5 commits into from Jun 1, 2018

Conversation

2 participants
@DrabWeb
Contributor

DrabWeb commented May 28, 2018

This logic was copy pasted everywhere, so I put it into a UpdateableBeatmapSetCover class. Functions similar to UpdateableAvatar.

@peppy peppy added the code quality label May 29, 2018

@peppy peppy added this to the June 2018 milestone May 29, 2018

@DrabWeb DrabWeb referenced this pull request May 29, 2018

Merged

Multiplayer shared logic encapsulation #2669

1 of 1 task complete
private void updateCover()
{
displayedCover?.FadeOut(400);
displayedCover?.Expire();

This comment has been minimized.

@peppy

peppy May 31, 2018

Member

probably best to set this to null here.

@@ -63,7 +62,7 @@ private void updateDisplay()
artist.Text = BeatmapSet?.Metadata.Artist ?? string.Empty;
onlineStatusPill.Status = BeatmapSet?.OnlineInfo.Status ?? BeatmapSetOnlineStatus.None;
cover?.FadeOut(400, Easing.Out);
cover.BeatmapSet = null;

This comment has been minimized.

@peppy

peppy May 31, 2018

Member

cover.BeatmapSet = BeatmapSet;

and remove the line below.

@peppy peppy added the pending review label Jun 1, 2018

@peppy

peppy approved these changes Jun 1, 2018

nice job

@peppy peppy changed the title from Updateable beatmap set cover to Centralise beatmap set cover update logic Jun 1, 2018

@peppy peppy merged commit 03cc4e8 into ppy:master Jun 1, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment