Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralise beatmap set cover update logic #2667

merged 5 commits into from Jun 1, 2018


Copy link

@DrabWeb DrabWeb commented May 28, 2018

This logic was copy pasted everywhere, so I put it into a UpdateableBeatmapSetCover class. Functions similar to UpdateableAvatar.

@peppy peppy added this to the June 2018 milestone May 29, 2018
private void updateCover()

This comment was marked as off-topic.

@@ -63,7 +62,7 @@ private void updateDisplay()
artist.Text = BeatmapSet?.Metadata.Artist ?? string.Empty;
onlineStatusPill.Status = BeatmapSet?.OnlineInfo.Status ?? BeatmapSetOnlineStatus.None;

cover?.FadeOut(400, Easing.Out);
cover.BeatmapSet = null;

This comment was marked as off-topic.

Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@peppy peppy changed the title Updateable beatmap set cover Centralise beatmap set cover update logic Jun 1, 2018
@peppy peppy merged commit 03cc4e8 into ppy:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants