Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplayer shared logic encapsulation #2669

Merged
merged 9 commits into from Jun 1, 2018

Conversation

2 participants
@DrabWeb
Copy link
Contributor

DrabWeb commented May 29, 2018

Moves some shared logic between DrawableRoom and RoomInspector into their own classes.

  • BeatmapTitle - Beatmap title/artist and saying "Changing map" when beatmap is null.
  • BeatmapTypeInfo - Beatmap and GameType info from RoomInspector, to be shared with the Match screen.
  • ParticipantCount - Count and max amount of participants from RoomInspector, to be shared with the Match screen.

DrabWeb added some commits May 29, 2018

Add BeatmapTitle to encapsulate multiplayer beatmap title display logic.
(cherry picked from commit 58e65afb45fbc675186e470cc4a268d9eaa2a539)
Move RoomInspector info panel content to BeatmapModeInfo to share wit…
…h Match.

(cherry picked from commit 257d9d13ac81d85583314f8b5dfabf05661b1572)
Cleanup.
(cherry picked from commit fffa6a004cf074caf0cf5c8ae1408a80500859fa)

peppy added some commits Jun 1, 2018

@peppy
Copy link
Member

peppy left a comment

👍

@peppy peppy dismissed their stale review via b9c6010 Jun 1, 2018

@peppy

peppy approved these changes Jun 1, 2018

@peppy peppy merged commit 6b48370 into ppy:master Jun 1, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.