New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type property to MultiplayerScreen #2672

Merged
merged 3 commits into from May 31, 2018

Conversation

2 participants
@DrabWeb
Contributor

DrabWeb commented May 29, 2018

Accidentally got removed in #2603.

@peppy peppy added the multiplayer label May 30, 2018

@peppy peppy added this to the June 2018 milestone May 30, 2018

/// <summary>
/// The type to display in the title of the <see cref="Header"/>.
/// </summary>
public abstract string Type { get; }

This comment has been minimized.

@peppy

peppy May 31, 2018

Member

Type => Title for a sane default? then you don't need to add anything to Lounge.

@@ -86,14 +86,14 @@ public Header(Screen initialScreen)
},
};
breadcrumbs.Current.ValueChanged += s => screenTitle.Text = ((MultiplayerScreen)s).Title;
breadcrumbs.Current.ValueChanged += s => screenType.Text = ((MultiplayerScreen)s).Type;

This comment has been minimized.

@peppy

peppy May 31, 2018

Member

consider applying ToLower() here since the design enforces lowercase.

@peppy

peppy approved these changes May 31, 2018

@peppy peppy merged commit 5d103a0 into ppy:master May 31, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment