Fix logo animation discrepancies #2682
Merged
Conversation
|
I'm a little bit sketched out by the buttonSystem.Alpha delay stuff, but let's see how many times we have to rewrite this before we recognise this entire thing is absurdly complex and teetering on the edge of unmaintainability. |
|
Completely agree. To make this manageable, each of the components with state changes needs to be split into its own drawable class, as we're doing everywhere else these days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Resolves #2282.