Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix logo animation discrepancies #2682
Conversation
peppy
added some commits
May 30, 2018
peppy
added
the
resolves issue
label
May 30, 2018
smoogipoo
added some commits
May 31, 2018
This comment has been minimized.
This comment has been minimized.
|
I'm a little bit sketched out by the buttonSystem.Alpha delay stuff, but let's see how many times we have to rewrite this before we recognise this entire thing is absurdly complex and teetering on the edge of unmaintainability. |
This comment has been minimized.
This comment has been minimized.
|
Completely agree. To make this manageable, each of the components with state changes needs to be split into its own drawable class, as we're doing everywhere else these days. |
smoogipoo
merged commit 824d6ae
into
ppy:master
May 31, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
peppy
deleted the
peppy:fix-osu-logo-discrepancies
branch
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
peppy commentedMay 30, 2018
Resolves #2282.