Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo animation discrepancies #2682

Merged
merged 6 commits into from May 31, 2018
Merged

Conversation

@peppy
Copy link
Member

@peppy peppy commented May 30, 2018

Resolves #2282.

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 31, 2018

I'm a little bit sketched out by the buttonSystem.Alpha delay stuff, but let's see how many times we have to rewrite this before we recognise this entire thing is absurdly complex and teetering on the edge of unmaintainability.

@peppy
Copy link
Member Author

@peppy peppy commented May 31, 2018

Completely agree.

To make this manageable, each of the components with state changes needs to be split into its own drawable class, as we're doing everywhere else these days.

@smoogipoo smoogipoo merged commit 824d6ae into ppy:master May 31, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy peppy deleted the peppy:fix-osu-logo-discrepancies branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.