Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storyboard icon and fix preview button overlap on direct panels #2695

Merged
merged 4 commits into from Jun 1, 2018

Conversation

Joehuu
Copy link
Sponsor Member

@Joehuu Joehuu commented May 31, 2018

Bug fixes:
Play button is now on top of status container.
No more overlaps from the two.

Changes and additions:
Added storyboard marker (not yet implemented on web).
Removed from in front of source.
Uses the stop icon instead of the pause icon.

@peppy peppy added the overlays label May 31, 2018
@peppy peppy added this to the Candidate Issues milestone May 31, 2018
@peppy peppy added the design label May 31, 2018
@peppy peppy modified the milestones: Candidate Issues, June 2018 Jun 1, 2018
@peppy
Copy link
Sponsor Member

peppy commented Jun 1, 2018

In the future, please split each of these changes into their own PR (ie. one for adding the storyboard logo, one for fixing the transition / depth).

@peppy peppy changed the title Match beatmapset panel with web Add storyboard icon and fix preview button overlap on direct panels Jun 1, 2018
@peppy peppy merged commit 53b1115 into ppy:master Jun 1, 2018
@Joehuu Joehuu deleted the match-panel-with-web branch June 1, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants