New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mania beatmap conversion #788

Merged
merged 38 commits into from May 19, 2017

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented May 18, 2017

Sorry about the length of this PR. I tried to keep it as short as possible to get things in a state where they can be used for the actual generators (the generators themselves are each like 500 LoC...

Main things added to this PR:

  • Basic storage of events in Beatmap, and parsing of break events.
  • Structure of the mania beatmap converter.
  • Structure of mania "pattern" generators and patterns.
  • Implementation of parsing hold notes.

@smoogipoo smoogipoo referenced this pull request May 18, 2017

Merged

Mania distance object conversion #789

3 of 3 tasks complete

@smoogipoo smoogipoo referenced this pull request May 18, 2017

Merged

Mania endtime object conversion #790

3 of 3 tasks complete
Show outdated Hide outdated osu.Game.Rulesets.Mania/Beatmaps/LegacyBeatmapConverter.cs
default:
objects = generateConverted(original);
break;
case 3:

This comment has been minimized.

@peppy

peppy May 19, 2017

Member

as discussed, we probably want to avoid having constants like this. instead making a method at ruleset CreateBeatmapConstructor(bool isLegacy, bool isInCurrentRulesetFormat)

@peppy

peppy May 19, 2017

Member

as discussed, we probably want to avoid having constants like this. instead making a method at ruleset CreateBeatmapConstructor(bool isLegacy, bool isInCurrentRulesetFormat)

@peppy

peppy approved these changes May 19, 2017

@smoogipoo smoogipoo referenced this pull request May 19, 2017

Merged

Mania hitobject object conversion #800

3 of 3 tasks complete

@smoogipoo smoogipoo merged commit 9e9df4a into ppy:master May 19, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:mania-beatmap-conversion branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment